Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admit cents as the equave when generating equal temperaments #808

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Admit cents as the equave when generating equal temperaments #808

merged 1 commit into from
Aug 14, 2024

Conversation

frostburn
Copy link
Member

ref #803

@frostburn frostburn requested a review from Starshine09 August 14, 2024 12:34
@frostburn frostburn linked an issue Aug 14, 2024 that may be closed by this pull request
Equal temperaments with cents equaves generate syntax errors #803
Closed
@frostburn
Copy link
Member Author

Estimated time to review: 10 minutes

Starshine09
Starshine09 approved these changes Aug 14, 2024
View reviewed changes
Copy link

@Starshine09 Starshine09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Automated and manual tests passed

@frostburn frostburn merged commit ce94f17 into main Aug 14, 2024
2 checks passed
@frostburn frostburn deleted the generate-et-cents branch August 14, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starshine09 Starshine09 Starshine09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equal temperaments with cents equaves generate syntax errors
2 participants
@frostburn @Starshine09